Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop updating google.golang.org/api #1104

Closed
wants to merge 1 commit into from

Conversation

enocom
Copy link
Member

@enocom enocom commented Feb 17, 2022

As of googleapis/google-api-go-client#1428 and v0.69.0, the minimum Go version is Go 1.15.

As of googleapis/google-api-go-client#1428 and v0.69.0, the minimum Go version is Go 1.15.
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two open questions:

  1. How are we going to remember to unfreeze this?
  2. Do we need to reconsider our minimum version if they go client is jumping to 1.15?

@enocom
Copy link
Member Author

enocom commented Feb 18, 2022

I think we should follow the Go connector support policy (latest four versions).

However, the Google API Go client libraries support only the latest three versions, so unless we want to update our own policy, we still might have the occasional awkward mismatch.

@enocom
Copy link
Member Author

enocom commented Feb 18, 2022

As for unfreezing this, if we support only the latest four versions, we're just waiting for Go 1.18 to unfreeze this.

@kurtisvg kurtisvg closed this Feb 21, 2022
@enocom enocom deleted the ignore-google-api-go-client branch March 14, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants